Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SqlMapperExtensions.Async.cs #2032

Open
wants to merge 1 commit into
base: net5
Choose a base branch
from
Open

Update SqlMapperExtensions.Async.cs #2032

wants to merge 1 commit into from

Conversation

AlexTian2012
Copy link

Extract type judgment to private method

@AlexTian2012
Update SqlMapperExtensions.Async.cs
0f983c4 
Extract type judgment to private method
mgravell
mgravell reviewed Jan 22, 2024
View reviewed changes
Dapper.Contrib/SqlMapperExtensions.Async.cs
type = type.GetGenericArguments()[0];
}
}
isList = IsArrayAndGetElementType(ref type);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initialize inline with decl

mgravell
mgravell requested changes Jan 22, 2024
View reviewed changes
Copy link
Member

@mgravell mgravell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - nice catch of a dup; one minor nit, but: +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgravell mgravell mgravell requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexTian2012 @mgravell