Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first stab at v3 #1983

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

first stab at v3 #1983

wants to merge 1 commit into from

Conversation

mgravell
Copy link
Member

@mgravell mgravell commented Oct 15, 2023

Initial changes:

  • tfm net461 -> net462, so allow:
  • use BCL async interfaces on netfx
  • add net7 tfm to allow DbDataSource
  • remove this on SqlMapper connection methods
  • new DbConnectionExtensions
  • new DbDataSourceExtensions
  • add CommandFlags to all APIs
  • add CancellationToken to all async APIs
  • subst CommandType? = null to CommandType = default
  • subst int? = null (timeout) to int? = {some default TBD}

Not yet started: all multi-map APIs

To investigate: does CommandTimeout make sense on async APIs?

@mgravell
Copy link
Member Author

Xref #1976

@iamcarbon
Copy link

.NET 7.0 will be EOL on May 14, 2024. It may be worth skipping the .NET 7.0 target and requiring .NET8.0 for DbDataSource.

@mgravell
Copy link
Member Author

@iamcarbon for now I'm happy to keep net7 - that also gives us the ability to use the regex codegen tool (adding that to "main" right now, no API change except a net7 tfm); if net7 adds cost, and/or we want to add net8 APIs: that becomes more pressing, but right now: meh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants