diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst index e3fac712de4662..0167e7f1e8e3de 100644 --- a/clang/docs/ReleaseNotes.rst +++ b/clang/docs/ReleaseNotes.rst @@ -388,6 +388,9 @@ AST Matchers - Fixed an issue with the `hasName` and `hasAnyName` matcher when matching inline namespaces with an enclosing namespace of the same name. +- Fixed an ordering issue with the `hasOperands` matcher occuring when setting a + binding in the first matcher and using it in the second matcher. + clang-format ------------ diff --git a/clang/include/clang/ASTMatchers/ASTMatchers.h b/clang/include/clang/ASTMatchers/ASTMatchers.h index ca44c3ee085654..f1c72efc238784 100644 --- a/clang/include/clang/ASTMatchers/ASTMatchers.h +++ b/clang/include/clang/ASTMatchers/ASTMatchers.h @@ -6027,7 +6027,7 @@ AST_POLYMORPHIC_MATCHER_P2( internal::Matcher, Matcher1, internal::Matcher, Matcher2) { return internal::VariadicDynCastAllOfMatcher()( anyOf(allOf(hasLHS(Matcher1), hasRHS(Matcher2)), - allOf(hasLHS(Matcher2), hasRHS(Matcher1)))) + allOf(hasRHS(Matcher1), hasLHS(Matcher2)))) .matches(Node, Finder, Builder); } diff --git a/clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp b/clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp index 47a71134d50273..028392f499da3b 100644 --- a/clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp +++ b/clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp @@ -1745,6 +1745,18 @@ TEST(MatchBinaryOperator, HasOperands) { EXPECT_TRUE(notMatches("void x() { 0 + 1; }", HasOperands)); } +TEST(MatchBinaryOperator, HasOperandsEnsureOrdering) { + StatementMatcher HasOperandsWithBindings = binaryOperator(hasOperands( + cStyleCastExpr(has(declRefExpr(hasDeclaration(valueDecl().bind("d"))))), + declRefExpr(hasDeclaration(valueDecl(equalsBoundNode("d")))))); + EXPECT_TRUE(matches( + "int a; int b = ((int) a) + a;", + traverse(TK_IgnoreUnlessSpelledInSource, HasOperandsWithBindings))); + EXPECT_TRUE(matches( + "int a; int b = a + ((int) a);", + traverse(TK_IgnoreUnlessSpelledInSource, HasOperandsWithBindings))); +} + TEST(Matcher, BinaryOperatorTypes) { // Integration test that verifies the AST provides all binary operators in // a way we expect.