-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme support #150
Comments
Maybe I don't quite understand, but Maniwani has support at the (S)CSS level for themes, as that's how the theme selector at the corner of the page works (by switching the CSS file retrieved between the built-in Or were you asking for custom templating to emit different HTML? That would be a little wonky but workable with Jinja but probably more-or-less impossible with the React UI since React components emit their own HTML elements. On the other hand the way Maniwani is rendered with the React rework allows entirely separate frontends, since the Flask portion of Maniwani just fires JSON over HTTP at an admin-specified endpoint before taking the result and sending it to the browser. Not really the intention I had in mind when designing that part of the architecture and so there's no kind of switch or anything to swap frontends, but it's another possibility that could be implemented with fairly little work. Improving the default look-and-feel and moving away from Bootstrap is something I've been meaning to do for a while, preferably from scratch with liberal use of flexbox and CSS grid since browser support for both is pretty standardized - I'm definitely interested in any suggestions for improving the UI/UX in that regard. |
I meant it more like full frontend, including templates and css can be semi-easilly swapped. I like this frontend: https://gitgud.io/LynxChan/PenumbraLynx/-/tree/master/, and I have a herokuapp running with the default front, but there's no boards so you cannot really see what board view looks. |
Got it, then it sounds like the architecture of the in-progress React port is a lot closer to what you want - let me see if I can expand on the overview I gave in my previous comment: With the way things currently work on the So giving Maniwani full pluggable frontend support wouldn't be too hard, if that's what you're looking for - at least once |
I would like to see a theme support added, so that one can just use config to specify which frontend templates/styles to load and/or improve the current defaults.
The text was updated successfully, but these errors were encountered: