Feature module1 reflow #124
Conversation
| if resources['RunData'].is_mc: | ||
| has_mc_truth = packet_seg_bt is not None | ||
| else: | ||
| has_mc_truth = False |
There was a problem hiding this comment.
At this point has_mc_truth is redundant with resources['RunData'].is_mc
There was a problem hiding this comment.
Is there no weird situation where it's MC but without backtracking packets?
There was a problem hiding this comment.
We need to test this with 2x2 larndsim inputs.
There was a problem hiding this comment.
MC doesn't go through this part of the if-else statement. I changed this line to accommodate the change that had been made in the tai_ns shape, from (adc, sipm) to (adc)
There was a problem hiding this comment.
dumb question, what's the reason for this change?
There was a problem hiding this comment.
At some point the shape of tai_ns shaped from (n_adcs, n_channels) to (n_adcs), and this change accommodates for that. The change in dimensions had probably only been tested on mc, and this line of code is for data.
There was a problem hiding this comment.
Sorry that I didn't understand the details. Why it cannot be merged with adc64_event_generator.py?
There was a problem hiding this comment.
My understanding from @liviocali is that the file format for the 2x2 is different than that used for the single modules
There was a problem hiding this comment.
I'm also curious why it is set to 10 while the simulation version set it to 200. I'd imagine this parameter should be set the same?
There was a problem hiding this comment.
Do you mean here for the simulation version?
Module1 reflow, and makes proto_nd_flow scripts work on data.