Event building with external triggers #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating with different versions of BeamTrig event builder
…ix needed due to a larndsim issue)
krwood
requested changes
Mar 7, 2024
There was a problem hiding this comment.
I think we should move this into src/proto_nd_flow since we're now putting in 2x2 specific things. Otherwise, the code looks good to me by eye, but I did not run any explicit checks of my own. If you could include any plots from the checks you mentioned here, that would be nice for posterity
|
@krwood moved to |
krwood
approved these changes
Mar 8, 2024
This was referenced May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested the workflow until the charge light matching on
MiniRun5_1E19_RHC.larnd.0000666. The event building are functioning as expected. The timestamp seem to be fine in general. Sampled some event displays, and they are also fine. The charge light matching rate is 100%. Note currently the t0 of the event is the external trigger.