You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I suggest to implement a builder for the single module of the SAND ECAL endcap. In this way the code will be more readable and the resulting geometry much more easy to be navigated
Hi @ast0815, the "changes" was merged into #18. The plan is then to let experts check everything is ok and if it is the case then merge #18 with master. Please let me know if this plan is not ok and how to proceed
Both #18 and #23 (this one) are issues, not pull requests. If this is a duplicate of that other issue (or should be part of the discussion there), then we can close it as such. But as it is right now, also #18 is not merged into anything, since it does not actually have any code changes associated with it. And there needs to be a pull request to review code changes and do the merge.
I suggest to implement a builder for the single module of the SAND ECAL endcap. In this way the code will be more readable and the resulting geometry much more easy to be navigated
dunendggd/duneggd/Component/SandECalEndcap.py
Line 58 in b9e539b
The text was updated successfully, but these errors were encountered: