Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add builder for SAND ECAL endcap single module #23

Open
mt82 opened this issue Jan 9, 2024 · 3 comments
Open

Add builder for SAND ECAL endcap single module #23

mt82 opened this issue Jan 9, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@mt82
Copy link
Member

mt82 commented Jan 9, 2024

I suggest to implement a builder for the single module of the SAND ECAL endcap. In this way the code will be more readable and the resulting geometry much more easy to be navigated

for mod in range(0,16):

@ast0815 ast0815 added the enhancement New feature or request label Jan 9, 2024
@mt82 mt82 closed this as completed Jan 18, 2024
@ast0815
Copy link
Member

ast0815 commented Jan 18, 2024

Please only mark an issue as completed once the "fix" has been merged into the main branch. Anything in "private" branches might as well not exist.

@ast0815 ast0815 reopened this Jan 18, 2024
@mt82
Copy link
Member Author

mt82 commented Jan 18, 2024

Hi @ast0815, the "changes" was merged into #18. The plan is then to let experts check everything is ok and if it is the case then merge #18 with master. Please let me know if this plan is not ok and how to proceed

@ast0815
Copy link
Member

ast0815 commented Jan 18, 2024

Both #18 and #23 (this one) are issues, not pull requests. If this is a duplicate of that other issue (or should be part of the discussion there), then we can close it as such. But as it is right now, also #18 is not merged into anything, since it does not actually have any code changes associated with it. And there needs to be a pull request to review code changes and do the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants