Mrigan/new readme #234
Merged
Mrigan/new readme #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArturSztuc
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
I've already looked at the document a couple of times and made suggestion etc. offline -- it looks good to me, and I am happy with this README being approved without further changes.
I have made a few suggestions, but they are all small grammar things that can be omitted at this PR. Further changes, like optimizing the explanations and linking multiple documents etc. can be done at a later date, the most important thing now is to have a README, and this one is already well-written.
Co-authored-by: ArturSztuc <[email protected]>
Co-authored-by: ArturSztuc <[email protected]>
Co-authored-by: ArturSztuc <[email protected]>
Co-authored-by: ArturSztuc <[email protected]>
Co-authored-by: ArturSztuc <[email protected]>
Co-authored-by: ArturSztuc <[email protected]>
Co-authored-by: ArturSztuc <[email protected]>
Co-authored-by: ArturSztuc <[email protected]>
|
Thanks Artur, I have accepted all your comments. |
Minor suggested changes to the new README file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating (actual) README for the trigger.
Aimed to help newcomers, also explains development and briefly touches on running.
Links used for portions that evolve quickly.