Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this module compatible with Streams2? #3

Closed
q2dg opened this issue Oct 19, 2014 · 5 comments
Closed

Is this module compatible with Streams2? #3

q2dg opened this issue Oct 19, 2014 · 5 comments

Comments

@q2dg
Copy link

q2dg commented Oct 19, 2014

That's all

@DTrejo
Copy link
Owner

DTrejo commented Oct 19, 2014

I am not sure; it seems like the travis tests passes, but my local test wont run. did you find an alternative to this? i'd be happy to link to it from the readme. if you end up fixing this lib, please send me a PR and I will give you contrib access?

Cheers,
D

@michaelmior
Copy link
Collaborator

You may also wish to check out JSONParse.

Edit: I see you already did :) creationix/jsonparse#21

@q2dg
Copy link
Author

q2dg commented Oct 20, 2014

@michaelmior Yes ;-)
@DTrejo Well...it isn't exactly an alternative (it uses Ndjson instead of plain Json), but I can live at the moment with this: https://github.com/maxogden/ndjson .
Thanks a lot!!

@DTrejo
Copy link
Owner

DTrejo commented Oct 20, 2014

Take a quick look at my code; you'll see how simple it is. Assuming the
dependency still works (it should, it is pure JS, with no deps), then you'd
only have to change maybe 3 lines to adapt to the new streams API.

Cheers,
D

On Sun, Oct 19, 2014 at 6:08 PM, q2dg [email protected] wrote:

@michaelmior https://github.com/michaelmior Yes ;-)
@DTrejo https://github.com/DTrejo Well...it isn't exactly an
alternative (it uses Ndjson instead of plain Json), but I can live at the
moment with this: https://github.com/maxogden/ndjson .
Thanks a lot!!


Reply to this email directly or view it on GitHub
#3 (comment).

See my projects at dtrejo.com
Read my tips for developers dtrejo.com/blog

@q2dg
Copy link
Author

q2dg commented Oct 20, 2014

Ok. Thanks

@q2dg q2dg closed this as completed Oct 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants