Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete tag translations in french for ORCID and Researcher Profile #3590

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pilasou
Copy link
Contributor

@pilasou pilasou commented Oct 31, 2024

References

Add references/links to any related issues or PRs. These may include:

Description

Those french translations focus only on the ORCID module and Researcher Profile feature.

Contains all french translations for ORCID and Researcher Profile.
@tdonohue tdonohue added i18n / l10n Internationalisation and localisation, related to message catalogs 1 APPROVAL pull request only requires a single approval to merge labels Oct 31, 2024
@tdonohue tdonohue added this to the 9.0 milestone Oct 31, 2024
@tdonohue tdonohue added port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels Oct 31, 2024
Copy link
Contributor

@nimabehforouz nimabehforouz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the added French translations for ORCID and Researcher Profile reviewed and checked.

@tdonohue
Copy link
Member

tdonohue commented Nov 1, 2024

@pilasou : This looks good overall, but it cannot be merged because of linting errors. You should be able to see them by running npm run lint locally...and it may be possible to auto-fix them by running npm run lint --fix. They all appear to be small alignment errors in the json5 files.

Once those errors are fixed, the automated tests should pass & we can merge this. Thanks!

@pilasou
Copy link
Contributor Author

pilasou commented Nov 1, 2024

@tdonohue I just changed all the indent problems. I hope all tests will pass! I unsure how to use the npm run lint command, but fortunatly the indent problems were easy to spot.

@tdonohue
Copy link
Member

tdonohue commented Nov 1, 2024

@pilasou : It's closer now ! Just two lint errors remain. You can fix them manually, or you could try running npm run lint --fix on the commandline to see if it will fix them automatically.

@pilasou
Copy link
Contributor Author

pilasou commented Nov 1, 2024

Hi @tdonohue I corrected the 2 remaining errors. Should be ok now. I know how to better read test results for Lint errors! I will also run the test before committing changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release
Projects
Status: 🙋 Needs Reviewers Assigned
Development

Successfully merging this pull request may close these issues.

3 participants