Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Port dspace-8_x] Fixed Edit Item's Version History crashing #3412

Merged
merged 4 commits into from
Oct 11, 2024
Merged

[Port dspace-8_x] Fixed Edit Item's Version History crashing #3412

merged 4 commits into from
Oct 11, 2024

Conversation

alexandrevryghem
Copy link
Member

References

alexandrevryghem and others added 4 commits August 14, 2024 22:46
@alexandrevryghem
117287: Removed method calls returning observables from the item vers…
d09f529 
…ions overview
@alexandrevryghem
Merge branch 'w2p-117287_fix-item-version-performance-issues_contribu…
db4ea14 
…te-7.6' into dspace-8_x

# Conflicts:
#	src/app/item-page/versions/item-versions.component.html
#	src/app/item-page/versions/item-versions.component.ts
@alexandrevryghem
117287: Simplified the if conditions on the edit/save/discard buttons…
e30bfff 
… on item versions

(cherry picked from commit 04bbaf9)
@alexandrevryghem
[DURACOM-248] set function call result in a class attribute
5619d6b 
(cherry picked from commit 87cff6c)
@alexandrevryghem alexandrevryghem added bug component: versioning performance / caching Related to performance, caching or embedded objects claimed: Atmire Atmire team is working on this issue & will contribute back labels Oct 10, 2024
@alexandrevryghem alexandrevryghem added this to the 8.1 milestone Oct 10, 2024
@alexandrevryghem alexandrevryghem self-assigned this Oct 10, 2024
@tdonohue tdonohue self-requested a review October 11, 2024 11:47
tdonohue
tdonohue approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @alexandrevryghem ! Tested this today and works well on 8.x. Code looks like an accurate port as well.

@tdonohue tdonohue merged commit 3db6aba into DSpace:dspace-8_x Oct 11, 2024
13 checks passed
@tdonohue tdonohue mentioned this pull request Oct 11, 2024
Merged
12 tasks
@alexandrevryghem alexandrevryghem deleted the w2p-117287_fix-item-version-performance-issues_contribute-8_x branch October 11, 2024 19:27
@alexandrevryghem alexandrevryghem mentioned this pull request Oct 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdonohue tdonohue tdonohue approved these changes

Assignees

@alexandrevryghem alexandrevryghem

Labels
bug claimed: Atmire Atmire team is working on this issue & will contribute back component: versioning performance / caching Related to performance, caching or embedded objects
Projects
DSpace 8.x and 7.6.x Maintenance
Status: ✅ Done
Milestone
8.1
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandrevryghem @tdonohue