Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility when selecting a search filter #3385

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Andrea-Guevara
Copy link
Contributor

References

Description

Creation of a method which, when a search filter is clicked, announces to the user that the page will be reloaded and which filter has been selected.

Instructions for Reviewers

List of changes in this PR:

  • In the component “search-facet-option.component” the method “selectingFilter()” has been created which, making use of the services “LiveRegionService” and “TranslateService”, creates a message which, as soon as the search filter is clicked, announces to the user that the page will be reloaded and which filter is being applied.
  • The “filterService.minimizeAll()” method that used to be called directly in the html is now called in the new method that has been created and is applied after the reload message is announced.
  • New translation keys have been added.

Include guidance for how to test or review your PR.

  1. Go to the search area where the filters are applied https://sandbox.dspace.org/search?query=;
  2. Using a screen reader, select a filter and notice that a page reload message is announced.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug accessibility component: Discovery related to discovery search or browse system 1 APPROVAL pull request only requires a single approval to merge labels Oct 4, 2024
Copy link

github-actions bot commented Nov 1, 2024

Hi @Andrea-Guevara,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge accessibility bug component: Discovery related to discovery search or browse system merge conflict
Projects
Status: 🙋 Needs Reviewers Assigned
Development

Successfully merging this pull request may close these issues.

Search filter change reloads page without warning to user
2 participants