Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3288 - Enabled 'admin-div' only for Site Administrator #3308

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Simone-Ramundi
Copy link
Contributor

References

Description

This PR introduces a change to the CreateCommunityParentSelectorComponent to display the admin-div section only to users with Site Administrator privileges.

Instructions for Reviewers

The key changes include:

  • New isAdmin$ Observable: Added an isAdmin$ observable to the CreateCommunityParentSelectorComponent to track admin status.

  • Conditional Rendering: Added a <div> with data-test="admin-div" in the component's template, which is displayed only if isAdmin$ emits true.

  • Updated Tests: Adjusted the unit tests to check for the presence of the admin-div based on the admin status.

How to test:

  1. Log in as Community admin on https://demo.dspace.org/home
  2. On the admin bar, click on New -> Community
  3. Verify that the admin-div is not visible.

Screenshot from 2024-09-06 18-05-31

This will confirm that the admin-div is correctly shown or hidden based on the user's admin status.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug component: administrative tools Related to the admin menu or tools 1 APPROVAL pull request only requires a single approval to merge component: Community Community display or editing port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug component: administrative tools Related to the admin menu or tools component: Community Community display or editing port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release
Projects
Status: 🙋 Needs Reviewers Assigned
Development

Successfully merging this pull request may close these issues.

Community admins wrongly see the button to create top-level communities
2 participants