Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Port dspace-8_x] support for disabled elements for screen readers #3269

Open
wants to merge 14 commits into
base: dspace-8_x
Choose a base branch
from
Open

[Port dspace-8_x] support for disabled elements for screen readers #3269

wants to merge 14 commits into from

Conversation

jensvannerum
Copy link
Contributor

References

This is a backport to DSpace 8 of #3268

Description

see #3268

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@jensvannerum jensvannerum self-assigned this Aug 27, 2024
@tdonohue tdonohue mentioned this pull request Aug 27, 2024
Open
12 tasks
@tdonohue tdonohue changed the title support for disabled elements for screen readers 8.0 backport [Port dspace-8_x] support for disabled elements for screen readers Aug 27, 2024
@tdonohue tdonohue added this to the 8.1 milestone Aug 27, 2024
Jens Vannerum added 4 commits September 16, 2024 14:13
117544: PR feedback
e7d050d 
- added typedocs
- changed directive to only be present for buttons
- various other small fixes
117544: rename directive to be clear it should currently only be used…
aec970f 
… for buttons
117544: linting
eb5aada
117544: fix remaining bug
d3e87c6
@jensvannerum jensvannerum force-pushed the w2p-117544_support-for-disabled-elements-for-screen-readers-8.0 branch from 4f3009b to 8d560ea Compare September 18, 2024 10:40
@jensvannerum jensvannerum force-pushed the w2p-117544_support-for-disabled-elements-for-screen-readers-8.0 branch from 8d560ea to 7ade453 Compare September 18, 2024 11:08
@github-actions GitHub Actions
Copy link

Hi @jensvannerum,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jensvannerum jensvannerum

Labels
accessibility high priority merge conflict
Projects
DSpace 8.x and 7.6.x Maintenance
Status: 🙋 Needs Reviewers Assigned
Milestone
8.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jensvannerum @tdonohue