Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing i18n keys for OpenAIRE external sources. #2979

Merged
merged 1 commit into from
May 7, 2024

Conversation

tdonohue
Copy link
Member

References

Description

OpenAIRE is missing a lot of i18n keys, for example:

openaire-broken

This PR adds them & removes a few keys which were duplicated

Instructions for Reviewers

  • Check code
  • Verify that this fixes missing keys that can be found in import from external sources

@tdonohue tdonohue added bug i18n / l10n Internationalisation and localisation, related to message catalogs 1 APPROVAL pull request only requires a single approval to merge labels Apr 24, 2024
@tdonohue tdonohue added this to the 8.0 milestone Apr 24, 2024
Copy link
Member Author

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this immediately as it's just missing i18n keys. We can follow it up with further fixes if more missing keys are found. Will NOT be backported to 7.x, as the missing keys are for features created in 8.0

@tdonohue tdonohue merged commit 2aa0f95 into DSpace:main May 7, 2024
10 of 11 checks passed
@tdonohue tdonohue deleted the add_openaire_keys branch May 7, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug i18n / l10n Internationalisation and localisation, related to message catalogs
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

1 participant