[Port dspace-7_x] Added missing/incomplete breadcrumbs on create community/collection/item pages #2969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandrevryghem
added
bug
component: Discovery
|
@alexandrevryghem : For some strange reason this PR isn't running the CI builds or anything. I tried to kickstart it by changing the branch temporarily to Could you try to push an update or rebase to this PR to see if you can get them to run? |
…bs_contribute-7.4' into dspace-7_x # Conflicts: # src/app/collection-page/collection-page-routing.module.ts # src/app/community-page/community-page-routing.module.ts # src/app/core/core.module.ts # src/app/workflowitems-edit-page/workflowitems-edit-page-routing.module.ts # src/app/workspaceitems-edit-page/workspaceitems-edit-page-routing.module.ts # src/assets/i18n/en.json5
alexandrevryghem
force-pushed
the
w2p-112970_added-missing-breadcrumbs_contribute-7_x
branch
from
c1ec793
to
7d49666
Compare
|
@tdonohue: I forced pushed the branch and the CI succeeds now |
tdonohue
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
👍 Thanks @alexandrevryghem ! Tested this on the dspace-7_x branch with demo.dspace.org as the backend. Verified this fixes the bug with these breadcrumbs not appearing on all create/edit forms. I didn't see any issues with other pages either.
alexandrevryghem
deleted the
w2p-112970_added-missing-breadcrumbs_contribute-7_x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #2888 to
dspace-7_x