Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for registration verification to the register email form. #2931

Conversation

Leano1998
Copy link
Contributor

@Leano1998 Leano1998 commented Apr 15, 2024

References

Add references/links to any related issue:

Description

This is a really small PR, which fixes the new-user-registration if the verification is disabled.

Instructions for Reviewers

List of changes in this PR:

  • Added check for registrationVerification to the html-template file.

Currently, if you try to register on https://sandbox.dspace.org using the registration form, you get an error (documented in #2918). Currently it only works if the registration.verification.enabled is set to true. I added a small check, if the registrationVerfication is enabled or not and now it works for me.

Guideline for testing:

  • Set the registration.verification.enabled to false on the backend side
  • Start your frontend and try to register with a new email adress.

To check, if the captcha still works:

  • Activate the registration verification (registration.verification.enabled=true)
  • Test the different settings for google.recaptcha.version: v3/v2. And the google.recaptcha.mode: invisible (while using version v3)

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug high priority 1 APPROVAL pull request only requires a single approval to merge labels Apr 15, 2024
@tdonohue tdonohue self-requested a review April 15, 2024 14:38
@tdonohue tdonohue added this to the 8.0 milestone Apr 15, 2024
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @Leano1998 ! This appears to fix the bug.

@tdonohue tdonohue added the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label Apr 15, 2024
@tdonohue tdonohue merged commit a16139c into DSpace:main Apr 15, 2024
10 of 11 checks passed
@dspace-bot
Copy link
Contributor

Backport failed for dspace-7_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-7_x
git worktree add -d .worktree/backport-2931-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-2931-to-dspace-7_x
git switch --create backport-2931-to-dspace-7_x
git cherry-pick -x 36b92004b2522ab96f88559a1f7cadf07437daa7

@tdonohue
Copy link
Member

Disregard the above error. I just realized this bug doesn't affect dspace-7_x so it does NOT need to be ported.

@tdonohue tdonohue removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label Apr 15, 2024
@Leano1998
Copy link
Contributor Author

👍 Thanks @Leano1998 ! This appears to fix the bug.

No, Problem. I'm happy, it helped!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug high priority
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

DSpace 8 New User Registration does not work when recaptcha disabled
3 participants