Add check for registration verification to the register email form. #2931
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Add references/links to any related issue:
Description
This is a really small PR, which fixes the new-user-registration if the verification is disabled.
Instructions for Reviewers
List of changes in this PR:
Currently, if you try to register on https://sandbox.dspace.org using the registration form, you get an error (documented in #2918). Currently it only works if the
registration.verification.enabled
is set totrue
. I added a small check, if the registrationVerfication is enabled or not and now it works for me.Guideline for testing:
registration.verification.enabled
tofalse
on the backend sideTo check, if the captcha still works:
registration.verification.enabled=true
)google.recaptcha.version
:v3
/v2
. And thegoogle.recaptcha.mode
:invisible
(while using version v3)Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn lint
yarn check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.