Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header, navbar, and admin sidebar refactoring (minor fixes) #2859

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

davide-negretti
Copy link
Contributor

@davide-negretti davide-negretti commented Mar 7, 2024

References

Description

This PR fixes the color of breadcrumb links

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@davide-negretti davide-negretti marked this pull request as ready for review March 8, 2024 10:29
@tdonohue tdonohue added accessibility 1 APPROVAL pull request only requires a single approval to merge labels Apr 10, 2024
@tdonohue tdonohue added this to the 8.0 milestone Apr 10, 2024
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @davide-negretti ! This looks correct. Gave it a brief test to make sure it works and it does.

@tdonohue tdonohue merged commit a3894a1 into DSpace:main Apr 10, 2024
13 checks passed
@davide-negretti davide-negretti deleted the DURACOM-195-fixes branch April 23, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge accessibility
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants