Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite scroll #2768

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Fix infinite scroll #2768

merged 1 commit into from
Apr 19, 2024

Conversation

Sondissimo
Copy link
Contributor

@Sondissimo Sondissimo commented Jan 24, 2024

References

Description

Fix for infinite scroll.

Instructions for Reviewers

The selector for the infinite scroll wasn't targeting the right infinitescroll container.

List of changes in this PR:
Changed infinitescrollcontainer to use id
Added a random seed made of alphanumerical character to avoid duplicated id

Include guidance for how to test or review your PR.

  1. Go into MyDSpace
  2. Then try to add for example a new publication
  3. When the list of collections is shown scroll down
  4. Make sure the infinite scrolldown works

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.

@tdonohue tdonohue added bug component: MyDSpace 1 APPROVAL pull request only requires a single approval to merge port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels Jan 24, 2024
@kanasznagyzoltan
Copy link

kanasznagyzoltan commented Apr 10, 2024

I have tested this PR using the sandbox.dspace.org as DSpace backend.
At the time of my test (2024.04.10 22:30 CET Time) there were 66 collections in the sandbox repository.
I could reproduced the problem in the sandbox frontend (sandbox.dspace.org) , so I could confirm this PR solved me the problem tested with locally run frontend:

  • when I click on the "All of DSpace" button, the displayed collection dropdown shows all element and if I am scrolling down and it is loading the new elements until all the collection is loaded.
  • when I click on the Plus icon to create a new publication is also working. If you choose to create new item there are 17 collections which are also loaded totally and displayed.

@tdonohue tdonohue self-requested a review April 11, 2024 14:50
@tdonohue tdonohue added this to the 8.0 milestone Apr 11, 2024
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @Sondissimo ! I verified this is also working for me and fixes the bug

@tdonohue tdonohue merged commit e96ca2f into DSpace:main Apr 19, 2024
13 checks passed
@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-7_x:

@tdonohue tdonohue removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug component: MyDSpace
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Infinite scroll not working when in mydspace
4 participants