Multiline selected facet badge on search page #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-search-filter-badge_main
tdonohue
added
bug
component: Discovery
|
Hi @LotteHofstede, |
|
Hi @LotteHofstede, |
tdonohue
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
👍 Thanks @LotteHofstede ! Finally got around to testing this and I can verify the bug exists & that this fixes it.
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-7_x
git worktree add -d .worktree/backport-2675-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-2675-to-dspace-7_x
git switch --create backport-2675-to-dspace-7_x
git cherry-pick -x f4dc8ca3d222f774b4424b9dae44577386ca1a28 a026c65a3c6970fae8b72c00667f500a0cff813c |
|
Manually ported to 7.x in #2989 |
tdonohue
removed
the
port to dspace-7_x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
This PR fixes an issue where a selected facet badge would overflow the page instead of wrapping around to a new line.
Instructions for Reviewers
Use a long facet filter that would overflow the page and make sure it wraps its text around to a new line. Add multiple facets to make sure everything still works as expected, Eg:
http://localhost:4000/search?query=test&spc.page=1&f.subject=Lorem%20ipsum%20dolor%20sit%20amet.%20Et%20iusto%20omnis%20qui%20reprehenderit%20illo%20ut%20provident%20cumque%20ab%20perspiciatis%20delectus.%20Eos%20nemo%20mollitia%20qui%20omnis%20nihil%20ut%20galisum%20obcaecati.,equals&f.author=test,equals&f.author=test123,equals
Checklist
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.