Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File edit component updated to work for forms without access conditions. #2647

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

mspalti
Copy link
Member

@mspalti mspalti commented Nov 17, 2023

Description

Bug fix. Saving bitstream edits is failing when the submission form does not include access conditions. This PR adds a check that prevents access condition processing when the property doesn't exist in the form.

Instructions for Reviewers

This can be tested by removing access options from the UploadConfiguration (by removing all "ref" tags). Then upload and edit a bitstream in the submission form. Try to save the changes. Prior to applying this PR you should see an error in console.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@mspalti mspalti assigned mspalti and unassigned mspalti Nov 17, 2023
@tdonohue tdonohue added bug component: submission port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release 1 APPROVAL pull request only requires a single approval to merge labels Nov 17, 2023
Copy link
Contributor

@nwoodward nwoodward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Admittedly, I'm not sure why someone would remove all of the access conditions, but when I did so and deployed this locally it fixed the problem. The code looks good.

Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @mspalti ! Tested this as well today and it works as described. It hides the access conditions from the UI if they are not enabled.

@tdonohue tdonohue added this to the 8.0 milestone Feb 15, 2024
@tdonohue tdonohue merged commit 5c3f51b into DSpace:main Feb 15, 2024
13 checks passed
@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-7_x:

@tdonohue tdonohue removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug component: submission
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants