Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit-item view: random order of buttons in status tab #2633

Conversation

vNovski
Copy link
Contributor

@vNovski vNovski commented Nov 13, 2023

References

Fixes #2618

Description

The order should be fixed. Permanently deletion should be the last option.

Instructions for Reviewers

The order of the buttons in status tab is fixed

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue
Copy link
Member

@vNovski : If this PR is nearly ready, I'd love to consider this for the 7.6.1 release (which is due this week). However, that requires taking this PR out of "Draft" status. So, please let us know when it can be reviewed.

@vNovski vNovski marked this pull request as ready for review November 13, 2023 16:03
@atarix83
Copy link
Contributor

@tdonohue
ready to be reviewed

@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge component: Item (Archived) Item display or editing component: administrative tools Related to the admin menu or tools port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels Nov 13, 2023
@tdonohue tdonohue self-requested a review November 13, 2023 16:55
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @vNovski ! This appears to work well. I can verify that the deletion button is now always last. The code looks reasonable, and I'm not seeing any differences in behavior beyond button ordering.

@tdonohue tdonohue merged commit 7ad5a5b into DSpace:main Nov 13, 2023
11 checks passed
@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-7_x:

@tdonohue tdonohue added this to the 8.0 milestone Nov 13, 2023
@tdonohue tdonohue removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug component: administrative tools Related to the admin menu or tools component: Item (Archived) Item display or editing
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

edit-item view: random order of buttons in status tab
4 participants