Fix RequestService test sometimes failing in CICD #2561
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because tests are executed slower on CICD it can sometimes take one second or more to execute the
RequestService#setStaleByHref(href)
, when the test arrives inside the subscribe, a create newRequestStaleAction
with the current time is created (this can already be a few seconds afterRequestService#setStaleByHref(href)
was called). To prevent such errors we can just expect thatlastUpdated
will be a number instead of comparing the actual values. The purpose of that test is to check the type ofRequestUpdateAction
returned by the function and not the date when it was created, so this doesn't have any side effects. This is an example of such a failure.Checklist
yarn lint
yarn check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.