Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't capitalize metadata values in search #2502

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

alanorth
Copy link
Contributor

@alanorth alanorth commented Sep 19, 2023

References

Add references/links to any related issues or PRs. These may include:

Description

Don't apply .text-capitalize on selected metadata values in the search filters. We should not be changing the visual display of metadata values.

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

Navigate to the search page and select a metadata value in one filter. Confirm that the value is NOT capitalized when selected.

List of changes in this PR:

  • Remove .text-capitalize class from selected search filters

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

Don't capitalize metadata values for display purposes.
@alanorth alanorth added the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label Sep 19, 2023
@alanorth alanorth changed the base branch from main to dspace-7_x September 19, 2023 04:47
@alanorth alanorth added port to main This PR needs to be ported to `main` branch for the next major release quick win Pull request is small in size & should be easy to review and/or merge and removed port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels Sep 19, 2023
@tdonohue tdonohue added bug component: Discovery related to discovery search or browse system labels Sep 19, 2023
Copy link
Contributor

@nwoodward nwoodward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested and confirmed this PR gets rid of the extra capitalization.

@J4bbi J4bbi merged commit abd6c01 into DSpace:dspace-7_x Sep 25, 2023
1 check passed
@dspace-bot
Copy link
Contributor

Successfully created backport PR for main:

@alanorth alanorth deleted the undo-text-capitalize branch September 26, 2023 05:17
@tdonohue tdonohue added this to the 7.6.1 milestone Sep 26, 2023
@tdonohue tdonohue removed the port to main This PR needs to be ported to `main` branch for the next major release label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug component: Discovery related to discovery search or browse system quick win Pull request is small in size & should be easy to review and/or merge
Projects
Development

Successfully merging this pull request may close these issues.

Bootstrap CSS class inappropriately capitalizes metadata values in search filters
5 participants