Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2437 Correct and clarify commented-out code in several custom components #2438

Merged
merged 2 commits into from
Aug 23, 2023
Merged

2437 Correct and clarify commented-out code in several custom components #2438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0906234
2437 Correct and clarify commented-out code in several custom components
hardyoyo Aug 15, 2023
518cc71
fix lint error in workflow-item-send-back.component.ts
hardyoyo Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/themes/custom/app/footer/footer.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ import { FooterComponent as BaseComponent } from '../../../../app/footer/footer.

@Component({
selector: 'ds-footer',
// styleUrls: ['footer.component.scss'],
// styleUrls: ['./footer.component.scss'],
styleUrls: ['../../../../app/footer/footer.component.scss'],
// templateUrl: 'footer.component.html'
// templateUrl: './footer.component.html'
templateUrl: '../../../../app/footer/footer.component.html'
})
export class FooterComponent extends BaseComponent {
Expand Down
4 changes: 2 additions & 2 deletions src/themes/custom/app/header-nav-wrapper/header-navbar-wrapper.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ import { HeaderNavbarWrapperComponent as BaseComponent } from '../../../../app/h
*/
@Component({
selector: 'ds-header-navbar-wrapper',
// styleUrls: ['header-navbar-wrapper.component.scss'],
// styleUrls: ['./header-navbar-wrapper.component.scss'],
styleUrls: ['../../../../app/header-nav-wrapper/header-navbar-wrapper.component.scss'],
// templateUrl: 'header-navbar-wrapper.component.html',
// templateUrl: './header-navbar-wrapper.component.html',
templateUrl: '../../../../app/header-nav-wrapper/header-navbar-wrapper.component.html',
})
export class HeaderNavbarWrapperComponent extends BaseComponent {
Expand Down
4 changes: 2 additions & 2 deletions src/themes/custom/app/shared/auth-nav-menu/auth-nav-menu.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ import { fadeInOut, fadeOut } from '../../../../../app/shared/animations/fade';
*/
@Component({
selector: 'ds-auth-nav-menu',
// templateUrl: 'auth-nav-menu.component.html',
// templateUrl: './auth-nav-menu.component.html',
templateUrl: '../../../../../app/shared/auth-nav-menu/auth-nav-menu.component.html',
// styleUrls: ['auth-nav-menu.component.scss'],
// styleUrls: ['./auth-nav-menu.component.scss'],
styleUrls: ['../../../../../app/shared/auth-nav-menu/auth-nav-menu.component.scss'],
animations: [fadeInOut, fadeOut]
})
Expand Down
2 changes: 1 addition & 1 deletion src/themes/custom/app/shared/object-list/object-list.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { ObjectListComponent as BaseComponent} from '../../../../../app/shared/o
selector: 'ds-object-list',
// styleUrls: ['./object-list.component.scss'],
styleUrls: ['../../../../../app/shared/object-list/object-list.component.scss'],
// templateUrl: 'object-list.component.html'
// templateUrl: './object-list.component.html'
templateUrl: '../../../../../app/shared/object-list/object-list.component.html'
})

Expand Down
5 changes: 4 additions & 1 deletion .../app/workflowitems-edit-page/workflow-item-send-back/workflow-item-send-back.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ import { WorkflowItemSendBackComponent as BaseComponent } from '../../../../../a

@Component({
selector: 'ds-workflow-item-send-back',
// styleUrls: ['workflow-item-send-back.component.scss'],
// NOTE: the SCSS file for workflow-item-action-page does not have a corresponding file in the original
// implementation, so this commented out line below is a stub, here if you
// need it, but you probably don't need it.
// styleUrls: ['./workflow-item-send-back.component.scss'],
// templateUrl: './workflow-item-send-back.component.html'
templateUrl: '../../../../../app/workflowitems-edit-page/workflow-item-action-page.component.html'
})
Expand Down
Loading