Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): curation-task.task.registerdoi.label #2399

Conversation

mirkoscherf
Copy link
Contributor

References

Description

changed curation-task.task.register-doi.label back to curation-task.task.registerdoi.label and added German translation

Instructions for Reviewers

Renamed the translation string identifier in all json5 files it was already present and added a German translation.

List of changes in this PR:

  • curation-task.task.register-doi.label -> curation-task.task.registerdoi.label

Include guidance for how to test or review your PR.

  • Log in as admin
  • Go to curation tasks
  • Open Task dropdown
  • Last entry should show 'Register DOI' instead of curation-task.task.registerdoi.label

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR fixes an issue ticket, I've linked them together.

changed curation-task.task.register-doi.label back to
curation-task.task.registerdoi.label and added German translation
@mirkoscherf mirkoscherf changed the title fix(i18m): curation-task.task.registerdoi.label fix(i18n): curation-task.task.registerdoi.label Jul 26, 2023
@tdonohue tdonohue added bug i18n / l10n Internationalisation and localisation, related to message catalogs 1 APPROVAL pull request only requires a single approval to merge labels Jul 26, 2023
@tdonohue tdonohue added this to the 7.6.1 milestone Jul 26, 2023
@tdonohue tdonohue added the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label Jul 26, 2023
@tdonohue tdonohue self-requested a review July 27, 2023 14:32
@alanorth alanorth self-requested a review August 28, 2023 18:00
@alanorth
Copy link
Contributor

alanorth commented Aug 28, 2023

Thanks @mirkoscherf. I tested this and verified that the updated strings were present for the curation task. I checked English and Spanish, but the others should be fine as well.

@alanorth alanorth merged commit d38402b into DSpace:main Aug 28, 2023
10 checks passed
@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-7_x:

@tdonohue tdonohue modified the milestones: 7.6.1, 8.0 Aug 28, 2023
@tdonohue tdonohue removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label Aug 28, 2023
@mirkoscherf mirkoscherf deleted the 2398-i18n_curation-task.task.registerdoi.label branch October 23, 2023 13:00
4science-it pushed a commit to 4Science/dspace-angular that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug i18n / l10n Internationalisation and localisation, related to message catalogs
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

I18n: curation-task.task.registerdoi.label misspelling
4 participants