Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed delete eperson button #2386

Closed

Conversation

HamzaFarooqArif
Copy link

@HamzaFarooqArif HamzaFarooqArif commented Jul 20, 2023

References

Add references/links to any related issues or PRs. These may include:

Description

"Delete EPerson" button is removed from "Create EPerson" form along with its unit tests

Instructions for Reviewers

List of changes in this PR:

  • Navigate to "Create EPerson" form. "Delete EPerson" should be removed.

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug usability authorization related to authorization, permissions or groups 1 APPROVAL pull request only requires a single approval to merge labels Jul 20, 2023
@alexandrevryghem
Copy link
Member

I'm sorry @HamzaFarooqArif I didn't know that the issue #2289 existed, I just discoverd it while browsing though all the open issues. While I was working on issue #2302 I already fixed that problem not only on the ePerson & Group form but also for the epeople overview page. Because you removed the button altogether instead of just hiding it, the edit form now also doesn't have delete button anymore (which it still should have). Because I already fixed this issue in PR #2391 I think this PR can be closed.

@tdonohue
Copy link
Member

Closing in favor of #2391 (which also fixes this issue alongside others)

@tdonohue tdonohue closed this Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge authorization related to authorization, permissions or groups bug usability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove buttons "Delete EPerson" and "Reset Password" in "Create EPerson" form
3 participants