-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show error message from the password validation response #2378
Conversation
Thanks @milanmajchrak for the patch and the easy instructions. I reviewed this by testing on DSpace 7.6. Before, DSpace would display a toast saying that an error occurred: After, DSpace shows a message saying the password must be at least eight characters long: P.S. my only feedback would be to rebase this pull request branch to remove those two unwanted reverts. Better to fix that before merging so we don't have such commits in the main branch forever. You could simply "squash" these three commits into one so they contain the actual changes and force-push the branch. |
@milanmajchrak : Would you be willing to squash these 3 commits into one? It should be possible to do easily via something like If you are not able to do this or don't feel comfortable with git commandline, I can see if I can do it on your behalf. But that may require creating a new PR & cherry-picking these commits into it. |
ac476f8
to
e6546b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed by inspection after rebase. Looks good to me.
Successfully created backport PR for |
References
Add references/links to any related issues or PRs. These may include:
Description
When the user is changing the password the more specific validation error message is popped up instead of unclear, the default message. The error message is loaded from the response error message.
Instructions for Reviewers
Updated
profile-page.component.ts
: The validation patch response is processed in the way that the error message from the response is added into notification message.Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Try to change the password for some user.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn lint
yarn check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.