Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spanish translation (es.json5) #2367

Closed

Conversation

vlguerrero
Copy link
Contributor

Description

Update Spanish translation.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added i18n / l10n Internationalisation and localisation, related to message catalogs 1 APPROVAL pull request only requires a single approval to merge port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels Jul 14, 2023
@tdonohue tdonohue added this to the 8.0 milestone Jul 14, 2023
@tdonohue tdonohue self-requested a review July 31, 2023 14:46
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Hi @vlguerrero,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

@tdonohue
Copy link
Member

tdonohue commented Sep 8, 2023

@vlguerrero : My apologies that this PR was somehow forgotten/overlooked. It appears however that these missing Spanish translations have since been added to our codebase in #2448 . I've compared the two PRs, and while the translations sometimes differ, it appears that missing translations are now in our codebase.

If somehow there are still translations missing or overlooked, please do feel free to submit a new PR. I'll close this one though, as it appears to not add anything new. Again, apologies that we didn't respond earlier.. because of many summer holidays, PR reviews have gone more slowly the last few months.

@tdonohue tdonohue closed this Sep 8, 2023
@tdonohue tdonohue removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label Sep 8, 2023
@tdonohue tdonohue removed this from the 8.0 milestone Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs merge conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants