Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility Issue with zooming in on default thumbnail images. #3339

Open
tdonohue opened this issue Sep 23, 2024 · 4 comments · May be fixed by #3373
Open

Accessibility Issue with zooming in on default thumbnail images. #3339

tdonohue opened this issue Sep 23, 2024 · 4 comments · May be fixed by #3373
Assignees
Labels
accessibility bug help wanted Needs a volunteer to claim to move forward

Comments

@tdonohue
Copy link
Member

tdonohue commented Sep 23, 2024

Describe the bug

Default thumbnail wording breaks when zooming in. Tested in Chrome, Firefox and Edge. Occurs in DSpace version 8.x and 7.x

This occurs on every page that has the "No Thumbnail Available" image.

To Reproduce

Steps to reproduce the behavior:

  1. Go to Demo Site homepage.
  2. Start at 100% (default) zoom.
  3. Zoom in to 175% and notice the thumbnail wording breaks the box.

Expected behavior

The thumbnail wording should not break out of the box.

@tdonohue tdonohue added bug accessibility needs triage New issue needs triage and/or scheduling labels Sep 23, 2024
@manez
Copy link

manez commented Sep 23, 2024

This may break slightly differently in DSpace 7. Screenshot from Firefox:

image

@DanGastardelli
Copy link
Contributor

I tested it in DSpace 8 and it also seems to be solved. Screenshot taken using Google Chrome.
image

@tdonohue
Copy link
Member Author

@DanGastardelli : I still see this bug on demo.dspace.org, so it doesn't appear fixed. Here's what I see on Chrome 129.0.6668.71 (on Windows) when zoomed in at 175% on the homepage:

nothumbnail

As a sidenote, if I reload the page, the alignment will correct itself. So, it appears this bug only occurs on the initial zoom (i.e. start at 100% and zoom in to 175% in order to see the misalignment).

@tdonohue tdonohue added help wanted Needs a volunteer to claim to move forward and removed needs triage New issue needs triage and/or scheduling labels Sep 26, 2024
@DanGastardelli
Copy link
Contributor

Hello @tdonohue, I made a solution that may be interesting for this case. I changed the font size to 14px, so in all the scenarios mentioned there was a good result in my tests. The change is in this PR "#3373".

I await feedback,
Daniel Pais (Neki-it)

@alisaismailati alisaismailati self-assigned this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug help wanted Needs a volunteer to claim to move forward
Projects
Development

Successfully merging a pull request may close this issue.

4 participants