Opening a Lookup Relation Modal always brings you to the top of the Submission Form

[manuele-lorusso]

Describe the bug

Opening a lookup relation modal like of the configured author field (person entity) let jump the submission form at the top of the page.

In most cases, especially at the DSpace Demo Site, only the author relation field is configured at the top and therefore does not interfere. But if relation fields to other entities are configured further down, then it is very annoying for the user to scroll back to the last edited submission field.

Affects all versions of DSpace 7 and 8. At least the browsers Firefox and Chrome.

To Reproduce

Steps to reproduce the behavior:

1. Start a Submission with any user role at the DSpace Demo Site (https://demo.dspace.org/)

2. Scroll down to just above the author field like in this Screenshot and open the Lookup Modal with the magnifier icon:
   

3. See the result of the main submission form behind:
   

4. Close the Modal...same result.

Expected behavior

The position of the modal should be at the height of the field and not at the top edge of the submission.

Related work

Could not find any DSpace issues dealing with this or similar topics

[Andrea-Guevara]

Good afternoon @manuele-lorusso and @tdonohue, how are you?

Would the purpose of this issue be to leave the content of the modal like this?

[manuele-lorusso]

Hi @Andrea-Guevara, thank you for your answer.

For me it looks good. It seems that the modal opens related to the field or the actioned component and the modal is centralized.

How and where did you achieve this result? I would be interested in implementing it directly in our system and would also make a pull request if you don't want to do it.

[Andrea-Guevara]

Good morning @manuele-lorusso! I did a simple simulation using Inspect/DevTools to see if that was the purpose of the issue.

By default, the modal is configured to take up the entire page, but that doesn't stop you from making your own customizations. I analyzed the code and came up with this component: src/app/shared/form/builder/ds-dynamic-form-ui/relation-lookup-modal

Maybe this will help you. But I noticed that it's a dynamic component, so you need to watch out for changes in other places that also use the modal.