Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ESLint plugins to enforce DSpace-specific coding conventions #3265

Open
ybnd opened this issue Aug 26, 2024 · 0 comments · May be fixed by #3390
Open

New ESLint plugins to enforce DSpace-specific coding conventions #3265

ybnd opened this issue Aug 26, 2024 · 0 comments · May be fixed by #3390
Assignees
Labels
improvement testing framework Related specifically to Unit or Integration (e2e) Tests

Comments

@ybnd
Copy link
Member

ybnd commented Aug 26, 2024

Before committing to #2865 we'd already worked on a few ESLint rules for some common situations in DSpace:

  • Enforcing aliased imports like import { of as observableOf } from 'rxjs';
  • Making sure entry component decorators in themes actually include the theme name
  • Making sure entry component decorators are not duplicated
  • Enforcing that ThemedComponent wrappers do not set default values on inputs (see Fixed some themeable component default values not being overridable #2164)

We have prototypes for these four rules, and that we'd like to polish up and integrate into DSpace Angular's custom ESLint plugin

@ybnd ybnd added improvement needs triage New issue needs triage and/or scheduling testing framework Related specifically to Unit or Integration (e2e) Tests labels Aug 26, 2024
@DSpace DSpace deleted a comment Aug 26, 2024
@tdonohue tdonohue removed the needs triage New issue needs triage and/or scheduling label Aug 27, 2024
@alexandrevryghem alexandrevryghem linked a pull request Oct 7, 2024 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement testing framework Related specifically to Unit or Integration (e2e) Tests
Projects
Status: 🏗 In Progress
Development

Successfully merging a pull request may close this issue.

2 participants