Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider update of ng-dynamic-forms library to latest version #3226

Open
saschaszott opened this issue Jul 31, 2024 · 1 comment
Open

Consider update of ng-dynamic-forms library to latest version #3226

saschaszott opened this issue Jul 31, 2024 · 1 comment
Labels
component: submission dependencies Pull requests that update a dependency file help wanted Needs a volunteer to claim to move forward

Comments

@saschaszott
Copy link
Contributor

Problem Description

The submission form implementation in DS7 (and DS8) depends on the ng-dynamic-forms library. The current version of this library is 18 (released in mid of 2023). DS8 depends on version 16 (released in december 2022).

Note: There is / was some discussion about a replacement of the ng-dynamic-forms library in DS8. Some developers noted that this change would require a large amount of work. Perhaps it is easier to update the version of the ng-dynamic-forms library.

@saschaszott saschaszott added needs triage New issue needs triage and/or scheduling new feature labels Jul 31, 2024
@tdonohue
Copy link
Member

While I'm not against an upgrade, I think this doesn't "fix" the issues mentioned in #2216. The issue is that @ng-dynamic-forms is not being well maintained (even now, it's not yet updated to Angular 17 support, which is what DSpace 8 uses). So, this ticket could provide a way to temporarily improve ng-dynamic-forms by upgrading it. But, in the long term it's still better to find a way to migrate to Angular's own forms library.

So, I'll pull this over to the 9.0 board in case someone wants to work on this until we find a way to fix #2216.

@tdonohue tdonohue added help wanted Needs a volunteer to claim to move forward dependencies Pull requests that update a dependency file component: submission and removed new feature needs triage New issue needs triage and/or scheduling labels Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: submission dependencies Pull requests that update a dependency file help wanted Needs a volunteer to claim to move forward
Projects
Status: 📋 To Do
Development

No branches or pull requests

2 participants