Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete and Send back buttons on Workflow items perform the same action in Administer workflow section #3086

Open
GraziaQuercia opened this issue May 29, 2024 · 3 comments
Assignees
Labels
bug component: administrative tools Related to the admin menu or tools component: workflow help wanted Needs a volunteer to claim to move forward

Comments

@GraziaQuercia
Copy link

Describe the bug
In the Administer workflow page, in the case of “Workflow” items, both the “Delete” and the “Send back” buttons perform the same action, sending the selected item back to the workspace of its submitter.
We reproduced this behaviour both on DSpace 8 and DSpace 7.6.

To Reproduce

  • log in as admin
  • visit the Administer workflow section in the administration bar
  • search for items in Workflow
    When clicking on "Send back", the behaviour is correct, and the item gets sent back to the Workspace
DSpace.Repository.__.Administer.Workflow.mp4

When clicking on "Delete", the item is, again, sent back to the Workspace

DSpace.Repository.__.Administer.Workflow.1.mp4

Expected behavior
We have the “Delete” button also for “Workspace” items, and in that case, the item is permanently removed from the repository (we also have the modal to confirm the delete action). See video.
We suggest to have the same behaviour on the Delete button of an item in Workspace in the Administer Workflow section.

DSpace.Repository.__.Administer.Workflow.2.mp4

Related work
Looking at the 7.0 Beta 3 Release Notes, we have a reference on those buttons:

  • Administer Active Workflows allows Administrators to see every submission that is currently in the workflow approval process. From there, they have the option to delete Items (if they are no longer needed), or send them back to the workflow pool (to allow another user to review them). (Login as an Admin, Click "Administer Workflow" in sidebar)

Release Notes - DSpace 7.x Documentation - LYRASIS Wiki

If useful, we fixed the buttons not working on #2227

@GraziaQuercia GraziaQuercia added bug needs triage New issue needs triage and/or scheduling labels May 29, 2024
@tdonohue
Copy link
Member

That does sound like a bug. Pulling this over to the bug board. Needs a volunteer.

@tdonohue tdonohue added help wanted Needs a volunteer to claim to move forward component: workflow component: administrative tools Related to the admin menu or tools and removed needs triage New issue needs triage and/or scheduling labels May 29, 2024
@oscar-escire
Copy link
Contributor

Hi @tdonohue I'm part of eScire, We like to contribute working on this Issue, can you assign it to me?

I think will take about 15 hours to complete.

@tdonohue
Copy link
Member

tdonohue commented Sep 9, 2024

Thanks @oscar-escire ! I've assigned it to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug component: administrative tools Related to the admin menu or tools component: workflow help wanted Needs a volunteer to claim to move forward
Projects
Status: 🏗 In Progress
Development

No branches or pull requests

3 participants