Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"All of DSpace" menu in nav bar remains open and obscures site visibility when navigating by keyboard only #3085

Open
hostle83 opened this issue May 29, 2024 · 3 comments · May be fixed by #3581
Assignees
Labels
accessibility bug claimed: Atmire Atmire team is working on this issue & will contribute back e/6 Estimate in hours funded Task is funded via the DSpace Development Fund

Comments

@hostle83
Copy link

Describe the bug

Once opened by keyboard-only users, the "All of DSpace" menu in the nav bar remains open even when moving to other elements on the site and obscures visibility:


Screenshot 2024-05-29 085304

To Reproduce
Steps to reproduce the behavior:

  1. Go to the sandbox or demo site
  2. Use keyboard only to navigate to the All of DSpace menu item in the nav bar
  3. Open the menu by pressing Enter on keyboard
  4. Move out of the menu by pressing tab (multiple times, first have to move through the menu)

Expected behavior
The "All of DSpace" menu should close automatically once having moved out of it

Related work
This could potentially be a related issue: #3021

@hostle83 hostle83 added bug needs triage New issue needs triage and/or scheduling labels May 29, 2024
@tdonohue tdonohue added help wanted Needs a volunteer to claim to move forward accessibility and removed needs triage New issue needs triage and/or scheduling labels May 29, 2024
@atarix83
Copy link
Contributor

atarix83 commented Jul 1, 2024

@tdonohue @hostle83

4science is interested in working on this task and the related one #3021

Estimation is about 6h

@tdonohue tdonohue added e/6 Estimate in hours claimed: 4Science 4Science team is working on this issue & will contribute back funded Task is funded via the DSpace Development Fund and removed help wanted Needs a volunteer to claim to move forward labels Jul 1, 2024
@alexandrevryghem
Copy link
Member

We also discovered that the navbar could also not correctly expand with some screenreaders and I created a fix for this last week. I was planning on opening a PR for that this week but there were still a few minor tweaks that I was going to make this week 😅 . That PR completely refactors the way the expandable menu section works and also already fixes this issue 🤷

@tdonohue
Copy link
Member

tdonohue commented Jul 1, 2024

@alexandrevryghem and @atarix83 : Since @alexandrevryghem already has a fix, then I'll reassign this to his plate.

I know that @atarix83 is simply trying to help claim "accessibility" tickets, as the DSpace Steering has prioritized fixing them using money obtained via the DSpace Development Fund.

Therefore, @alexandrevryghem , if there are other "accessibility" tickets that you've already fixed / have fixes for, please ask to claim them soon. That'll ensure that we don't accidentally do duplicative work.

@tdonohue tdonohue assigned alexandrevryghem and unassigned atarix83 Jul 1, 2024
@tdonohue tdonohue added claimed: Atmire Atmire team is working on this issue & will contribute back and removed claimed: 4Science 4Science team is working on this issue & will contribute back labels Jul 1, 2024
@alexandrevryghem alexandrevryghem linked a pull request Oct 27, 2024 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug claimed: Atmire Atmire team is working on this issue & will contribute back e/6 Estimate in hours funded Task is funded via the DSpace Development Fund
Projects
Status: 🏗 In Progress
Development

Successfully merging a pull request may close this issue.

4 participants