Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfocused search component views in modals remain visible on mobile screens #2970

Closed
ybnd opened this issue Apr 22, 2024 · 2 comments
Closed
Assignees
Labels
bug component: Discovery related to discovery search or browse system ux User Experience related works
Milestone

Comments

@ybnd
Copy link
Member

ybnd commented Apr 22, 2024

Describe the bug
A clear and concise description of what the bug is. Include the version(s) of DSpace where you've seen this problem & what web browser you were using. Link to examples if they are public.

To Reproduce
Steps to reproduce the behavior:

  1. Edit an Entity in DSpace (e.g. from https://demo.dspace.org/search?query=dspace.entity.type:Publication&spc.page=1)
  2. Go to the "Relationships" tab
  3. Click on one of the "+ Add" buttons to open a lookup modal
  4. Resize the screen
    • You will see a small sliver of the search tools view on the left hand side
  5. Click on "Search tools"
    • You will still see a small sliver of the search results view on the right hand side
    • Because of the sliding animation this will be all the more noticeable

Expected behavior
The "Search tools" view should not be visible when the "Results" view is focused and vice versa.
The content should only be visible when it appears within the borders of the modal it is in.

@ybnd ybnd added bug component: Discovery related to discovery search or browse system needs triage New issue needs triage and/or scheduling ux User Experience related works labels Apr 22, 2024
@tdonohue tdonohue added help wanted Needs a volunteer to claim to move forward and removed needs triage New issue needs triage and/or scheduling labels Apr 22, 2024
@alexandrevryghem
Copy link
Member

I already fixed this on 8.0 in #2732, so I'm assigning myself in order to create a backport for the dspace-7_x branch

@alexandrevryghem alexandrevryghem self-assigned this Apr 23, 2024
@alexandrevryghem alexandrevryghem removed the help wanted Needs a volunteer to claim to move forward label Apr 23, 2024
@tdonohue tdonohue added this to the 7.6.2 milestone May 13, 2024
@tdonohue
Copy link
Member

Fixed by #3027 in 7.6.2. Fixed by #2732 in 8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug component: Discovery related to discovery search or browse system ux User Experience related works
Projects
Development

No branches or pull requests

3 participants