Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browse By Subject Category page has Swedish tooltips #2746

Open
doana opened this issue Jan 17, 2024 · 1 comment
Open

Browse By Subject Category page has Swedish tooltips #2746

doana opened this issue Jan 17, 2024 · 1 comment
Labels
bug component: controlled vocabulary related to controlled vocabulary or value-pairs dropdowns component: Discovery related to discovery search or browse system help wanted Needs a volunteer to claim to move forward

Comments

@doana
Copy link
Contributor

doana commented Jan 17, 2024

Regardless of the interface language selected by the user, the default SRSC browse page has Swedish tooltips. This behaviour can be observed on the demo instance.

To Reproduce
Steps to reproduce the behavior:

  1. Visit https://demo.dspace.org/browse/srsc
  2. Hover your mouse cursor over any of the terms in the vocabulary
  3. Observe that the resulting tooltip is in Swedish

image

Expected behavior
The tooltips should respect the language of the user's interface.

@doana doana added bug needs triage New issue needs triage and/or scheduling labels Jan 17, 2024
@tdonohue
Copy link
Member

tdonohue commented Jan 17, 2024

@doana : This behavior is simply because the tooltips use the <hasNote> fields in the Controlled Vocabulary. Those fields are currently hardcoded to Swedish as the SRSC vocabulary is the "Swedish Research Subject Categories". See the file where that vocabulary is defined: https://github.com/DSpace/DSpace/blob/main/dspace/config/controlled-vocabularies/srsc.xml#L9

So, it is not yet possible to translate these notes except by changing the <hasNote> values in that config file. I do agree it'd be nice to someday perhaps move these notes into i18n keys if others find this SRSC vocabulary generally useful. But, it's currently meant to be an example vocabulary.

I'll leave this ticket open in case someone does want to look at a better approach. But, the behavior here is currently "working as designed" since this is a Swedish controlled vocabulary.

@tdonohue tdonohue added help wanted Needs a volunteer to claim to move forward component: controlled vocabulary related to controlled vocabulary or value-pairs dropdowns component: Discovery related to discovery search or browse system and removed needs triage New issue needs triage and/or scheduling labels Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug component: controlled vocabulary related to controlled vocabulary or value-pairs dropdowns component: Discovery related to discovery search or browse system help wanted Needs a volunteer to claim to move forward
Projects
Status: 🙋 Needs Help / Unscheduled
Development

No branches or pull requests

2 participants