Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login box has large Whitespace when only a singular login option is enabled #2690

Closed
misilot opened this issue Dec 5, 2023 · 0 comments · Fixed by #2691
Closed

Login box has large Whitespace when only a singular login option is enabled #2690

misilot opened this issue Dec 5, 2023 · 0 comments · Fixed by #2691
Assignees
@misilot
Labels
authentication: general general authentication issues bug
Milestone
7.6.2

Comments

@misilot
Copy link
Contributor

misilot commented Dec 5, 2023 •
edited
Loading

Describe the bug
On DSpace 7.6.1 and the Demo site, when the login box only has a singular login option, there is a bunch of extra whitespace.

To Reproduce
Steps to reproduce the behavior:

  1. Disable Local Login, and only have one Login Option
  2. Click Login Dropdown, and see whitespace

This is because of

  .loginDropdownMenu {
    min-height: 260px;
  }
image

Expected behavior
If min-height is set to 75px, this rendered like this

image

and if have the full regular login box you get this

Screenshot 2023-12-05 at 9 57 12 AM

Related work
Will have a PR shortly
@misilot misilot added bug needs triage New issue needs triage and/or scheduling labels Dec 5, 2023
misilot added a commit to misilot/dspace-angular that referenced this issue Dec 5, 2023
@misilot
Decrease min-height for Login Dropdown Menu
09fc44a 
Fixes DSpace#2690

This is noticable when you have disabled local authentication, and only have a singular remote authentication such as Shibboleth or Orcid.
@misilot misilot mentioned this issue Dec 5, 2023
Merged
8 tasks
@tdonohue tdonohue added authentication: general general authentication issues and removed needs triage New issue needs triage and/or scheduling labels Dec 5, 2023
@tdonohue tdonohue added this to the 7.6.2 milestone Dec 5, 2023
github-actions bot pushed a commit that referenced this issue Jan 19, 2024
@misilot @github-actions
Decrease min-height for Login Dropdown Menu
d880b72 
Fixes #2690

This is noticable when you have disabled local authentication, and only have a singular remote authentication such as Shibboleth or Orcid.

(cherry picked from commit 09fc44a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@misilot misilot

Labels
authentication: general general authentication issues bug
Projects
DSpace 8.x and 7.6.x Maintenance
Status: ✅ Done
Milestone
7.6.2
Development

Successfully merging a pull request may close this issue.

Decrease min-height for Login Dropdown Menu misilot/dspace-angular
2 participants
@tdonohue @misilot