Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission form is cutoff / overlaps with side menu (in pre-7.6.1 only) #2557

Closed
tdonohue opened this issue Oct 20, 2023 · 3 comments · Fixed by #2558
Closed

Submission form is cutoff / overlaps with side menu (in pre-7.6.1 only) #2557

tdonohue opened this issue Oct 20, 2023 · 3 comments · Fixed by #2558

Comments

@tdonohue
Copy link
Member

Describe the bug
On latest main and dspace-7_x, the Submission form is cuttoff / overlaps with the sidebar menu. It appears to be a side effect of #2454 , as reverting those changes fixes the problem (when I try that locally)

See this screenshot
cutoff-submissionform

To Reproduce
Steps to reproduce the behavior:

  1. Can be reproduced on https://demo.dspace.org and https://sandbox.dspace.org (or locally via the latest code.
  2. Login and go to the Submission Form

Related work
Caused by #2454

@tdonohue
Copy link
Member Author

Solving this issue may require reverting #2454, unless a better fix can be found. Pinging you @floriangantner just in case you have time to help investigate.

@tdonohue
Copy link
Member Author

tdonohue commented Oct 20, 2023

Errors that appear in browser's DevTools Console on (seemingly) every page click after you login (when running in production mode: yarn build:prod; yarn serve:ssr):

ERROR Error: NG03402
    at Le (main.dcd17e51f7449cc8.js:1:1377219)
    at Io.reportError (main.dcd17e51f7449cc8.js:1:1377253)
    at Io._flushAnimations (main.dcd17e51f7449cc8.js:1:1379925)
    at Io.flush (main.dcd17e51f7449cc8.js:1:1376684)
    at ge.flush (main.dcd17e51f7449cc8.js:1:1388266)
    at main.dcd17e51f7449cc8.js:1:1396292
    at Z.invoke (polyfills.2583206b8351234c.js:1:17141)
    at Kt.run (polyfills.2583206b8351234c.js:1:12406)
    at Va.runOutsideAngular (main.dcd17e51f7449cc8.js:1:2126778)
    at ge.end (main.dcd17e51f7449cc8.js:1:1396231)

I think we need to revert #2454... it seems to have some unexpected side effects over the entire site. (These errors do NOT occur on every page click when #2454 is reverted)

@tdonohue
Copy link
Member Author

Fixed by reverting #2454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

1 participant