Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual differentiation needed for Access Status #2402

Closed
paulo-graca opened this issue Jul 27, 2023 · 5 comments · Fixed by #2579
Closed

Visual differentiation needed for Access Status #2402

paulo-graca opened this issue Jul 27, 2023 · 5 comments · Fixed by #2579
Assignees
Milestone

Comments

@paulo-graca
Copy link
Contributor

paulo-graca commented Jul 27, 2023

Describe the bug
Currently, when displaying different access status like open access, restricted access, ... there is no visual differentiation.
image

all look the same.

To Reproduce
Steps to reproduce the behavior:

  1. Firstly you should have content with different types of access (specific resource policies for open access, embargoed access)
  2. Activate the required configuration on your client site (angular):
# Item Config
item:
  showAccessStatuses: true
  1. Perform a query (can be an empty one and you will have a list of items). Please mind that this only applies to generic Items or Publications.

Expected behavior
I hoped to have a visual differentiation for different access status. Could be something based on a different color, a specific style class. Of course I can theme that component and do that on my side, but I think it makes more sense to have it like that for all implementations.

@paulo-graca paulo-graca added bug needs triage New issue needs triage and/or scheduling labels Jul 27, 2023
@pilasou
Copy link
Contributor

pilasou commented Aug 2, 2023

@paulo-graca I like the idea...but talking about color design always seems to me like a pandora's box! :) There are 4 status to cover: OA, Embargo, Restricted and Metadata only. Maybe it would be possible by following a simple color code (green for OA, red for restricted, etc.), like this:
image

My concern is that on a result page, it can look like fireworks:
image

@mwoodiupui
Copy link
Member

Please bear in mind that the four states are simply names for combinations of starting and ending dates for ResourcePolicy instances. Other combinations are possible. Here we have two types of embargo: limited (maximum of two years) and unlimited (can be embargoed "forever"). Collections use one or the other as required.

@tdonohue
Copy link
Member

Not against this idea, but priority is uncertain. It might be possible to simply make it easier for sites to color each status button differently via CSS...instead of defaulting to a specific color scheme (which can be a "pandora's box" as @pilasou notes)

For now, moving this to backlog as priority is unclear to me.

@tdonohue tdonohue added themes help wanted Needs a volunteer to claim to move forward and removed needs triage New issue needs triage and/or scheduling labels Aug 17, 2023
@paulo-graca
Copy link
Contributor Author

Concluding, to avoid fireworks It would be better to add specific stylesheet classes, perhaps based on the access status itself, like:

<span class="badge badge-secondary access-status-value open-access">Open Access</span>

then, anyone can custom it as it pleases.

@paulo-graca
Copy link
Contributor Author

@pilasou @mwoodiupui @tdonohue I've just created this tiny PR to address this:
#2579

@tdonohue tdonohue added this to the 7.6.1 milestone Nov 13, 2023
@tdonohue tdonohue removed the help wanted Needs a volunteer to claim to move forward label Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

4 participants