Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SiteImprove revealed dspace code accessibility Issues #2055

Closed
emj73 opened this issue Jan 24, 2023 · 5 comments
Closed

SiteImprove revealed dspace code accessibility Issues #2055

emj73 opened this issue Jan 24, 2023 · 5 comments
Assignees
Milestone

Comments

@emj73
Copy link

emj73 commented Jan 24, 2023

We ran a SiteImprove audit on our dev dpsace 7 and the following issues were revealed that target dspace out of the box code: [https://cornell.box.com/s/xo17pd4sfcrd314dul32w70lbdqsg8i8]

please let me know if you are unable to access that link.

thanks for considering :)

@emj73
Copy link
Author

emj73 commented Jan 24, 2023

for ease, here is the info from the doc copied:

Headings are not structured

  • Headings are out of order.

https://demo7.dspace.org/items/a1283d9b-8702-46ee-acb8-1d19302349b2

Item title is H2. Next heading is H5 (Files, Date, Author, etc.).

Element IDs are not unique

  • The element search-container-navbar appears twice in the header code.

https://github.com/DSpace/dspace-angular/tree/main/src/app/search-navbar

https://demo7.dspace.org/items/a1283d9b-8702-46ee-acb8-1d19302349b2

State or property not supported

  • Aria-disabled attribute is not supported on an tag in this context. This is on disabled links in pagination.

https://demo7.dspace.org/search?query=history

...

Button missing a text alternative

  • There is a button that does not actually display in this view, but the HTML is still there. It comes before the “Show more” button in the code. If you run the WAVE plugin on this page it shows four instances of empty buttons.

https://demo7.dspace.org/community-list

Example:

@emj73
Copy link
Author

emj73 commented Jan 24, 2023

some of the above comment cut off:

Button missing a text alternative

  • There is a button that does not actually display in this view, but the HTML is still there. It comes before the “Show more” button in the code. If you run the WAVE plugin on this page it shows four instances of empty buttons.

https://demo7.dspace.org/community-list

Example:

@tdonohue
Copy link
Member

At a quick glance, I believe many of these issues overlap with existing, open accessibility tickets: https://github.com/DSpace/dspace-angular/issues?q=is%3Aissue+is%3Aopen+accessibility+label%3Aaccessibility

We are aware there are a number of buttons with missing text, non-unique elements, etc. We've slowly been fixing those in page-specific accessibility tickets.

@tdonohue tdonohue added help wanted Needs a volunteer to claim to move forward accessibility good first issue This is a smaller ticket/bug that may be easier for new contributors labels Feb 23, 2023
@tdonohue
Copy link
Member

tdonohue commented Dec 6, 2023

In testing #2683, I've reanalyzed this ticket.

I believe all the issues in this ticket have now been fixed on main and dspace-7_x except for the empty buttons issue on /community-list. I'm going to split that out into a new ticket, as it's the only remaining issue. Everything else here is no longer reproducible.

@tdonohue tdonohue added bug and removed help wanted Needs a volunteer to claim to move forward good first issue This is a smaller ticket/bug that may be easier for new contributors labels Dec 6, 2023
@tdonohue tdonohue added this to the 7.6.2 milestone Dec 6, 2023
@tdonohue
Copy link
Member

tdonohue commented Dec 6, 2023

Closing this ticket as Fixed (as of 7.6.2). The remaining issue has been moved to #2697.

@tdonohue tdonohue closed this as completed Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants