Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deque Analysis] Item Edit "Status" Tab "serious" accessibility issues #1190

Closed
tdonohue opened this issue May 13, 2021 · 3 comments · Fixed by #3148
Closed

[Deque Analysis] Item Edit "Status" Tab "serious" accessibility issues #1190

tdonohue opened this issue May 13, 2021 · 3 comments · Fixed by #3148
Assignees
Labels
Milestone

Comments

@tdonohue
Copy link
Member

tdonohue commented May 13, 2021

Serious: This issue results in serious barriers for people with disabilities, and will partially prevent them from accessing fundamental features or content. People relying on assistive technologies will experience significant frustration as a result. Issues falling under this category are major problems, and remediation should be a priority.

Deque Analysis Summary

Our Item Edit "Status" tab has a total of 5 serious accessibility issues (not including color contrast which are handled in other tickets).

  1. (IDs 470076, 471046, 471452) "Selected state of the element is missing or incorrect." on all the tabs (not just Status). When a specific tab is active it should have aria-current or aria-selected specified to note the currently active page/tab. FIXED by aria-selected added to Item Edit "Status" Tab. Fixed ID: 470076 #2063
  2. (ID 470077) "Purpose of the link is not clear in context." on the "Withdraw..." and "Move..." buttons/links (on Status tab). The links should have more detail ("Withdraw this Item" "Move this Item to a different Collection") either in the text itself, or in an aria-label. FIXED by fixed ID 470077. Purpose of the link is not clear in context #2062
  3. (ID 471072) Content overlap at 320px width. When the browser has 320px width, the entire page suffers from content overlap. FIXED BY Accessibility of the status page #3148

Full list of issues is viewable at (requires login): https://axeauditor.dequecloud.com/test-run/0856438a-a19a-11eb-bc31-b7d5be387c86/issues?activeTab=dt-issue&page=0&pageSize=50&sortField=ordinal&sortDir=asc&row=9&filter%5Bseverity%5D=3&filter%5Btype%5D=issue&filter%5Bpage_number%5D=12

More Information / Tools

@tdonohue tdonohue added this to the 7.0 milestone May 13, 2021
@tdonohue tdonohue modified the milestones: 7.0, 7.1 Jul 28, 2021
@tdonohue tdonohue removed this from the 7.1 milestone Oct 27, 2021
@tdonohue tdonohue added help wanted Needs a volunteer to claim to move forward good first issue This is a smaller ticket/bug that may be easier for new contributors labels May 20, 2022
CrisGuzmanS added a commit to CrisGuzmanS/dspace-angular that referenced this issue Jan 30, 2023
4science-it pushed a commit to 4Science/dspace-angular that referenced this issue Jan 9, 2024
Change section labels according to changes done in the submission form excel file
@Andrea-Guevara
Copy link
Contributor

Good morning, @tdonohue! My name is Andrea Guevara and I'm part of Neki-it. I'd like to contribute a solution to this issue. We could solve the problem of overlap between the text and the buttons on the status page in two ways: In the first approach, we reduced the size of the texts to generate more space on the screen and in the second approach, we used grid system classes to improve responsiveness.

issue-#1190-1
issue-#1190-2

Looking forward to your feedback!

@tdonohue
Copy link
Member Author

@Andrea-Guevara : Thanks for your suggestions. I, personally, would prefer the second approach (as there is less wrapping of text). But, I'm not against the first approach if it's much easier to achieve.

I'll assign this to you to make others aware you / Neki-it are working on it.

@tdonohue tdonohue removed help wanted Needs a volunteer to claim to move forward Estimate TBD good first issue This is a smaller ticket/bug that may be easier for new contributors labels Jun 25, 2024
Andrea-Guevara pushed a commit to Neki-IT/dspace-angular that referenced this issue Jun 26, 2024
…status page using the item-operation component
@Andrea-Guevara
Copy link
Contributor

Good morning @tdonohue! I provided a PR with the second approach #3148
If you have any suggestions or questions, please get in touch!

github-actions bot pushed a commit that referenced this issue Oct 2, 2024
… page using the item-operation component

(cherry picked from commit e06b67f)
@tdonohue tdonohue added this to the 7.6.3 milestone Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

3 participants