Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New /api/security/csrf endpoint & updated CSRF docs #259

Merged
merged 2 commits into from
May 16, 2024

Conversation

tdonohue
Copy link
Member

@tdonohue tdonohue commented Mar 22, 2024

Documentation for the new GET /api/security/csrf endpoint added by DSpace/DSpace#9321

Adding more details to the documentation on CSRF Token behavior, by including details on how the User Interface interacts with the REST API with regards to CSRF tokens.

@tdonohue tdonohue added 1 APPROVAL pull request only requires a single approval to merge. port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels Mar 22, 2024
@tdonohue tdonohue changed the title Update docs on CSRF Tokens New /api/security/csrf endpoint & updated CSRF docs Mar 28, 2024
@tdonohue tdonohue added this to the 8.0 milestone Mar 28, 2024
@tdonohue tdonohue changed the title New /api/security/csrf endpoint & updated CSRF docs New /api/security/csrf endpoint & updated CSRF docs Mar 29, 2024
@tdonohue tdonohue removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label Apr 1, 2024
@tdonohue tdonohue requested a review from abollini April 18, 2024 15:01
@tdonohue
Copy link
Member Author

Assigning to @abollini for feedback on this Contract & also whether we should backport this to 7.x as this endpoint (along with minor changes to the Angular UI) fixes this bug DSpace/DSpace#9236 (and that bug also impacts 7.x)

Copy link
Member

@abollini abollini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @tdonohue it looks good to me

@tdonohue tdonohue added the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label May 16, 2024
@tdonohue
Copy link
Member Author

Merging to main. I've also added the port to dspace-7_x flag as this fix should be ported to 7.x (along with the implementation code -- I'll create PRs for those as well.)

@tdonohue tdonohue merged commit b3d5eec into main May 16, 2024
1 check passed
@dspace-bot
Copy link

Successfully created backport PR for dspace-7_x:

@tdonohue tdonohue removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge.
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Bug in statistics gathering upon first visit of repository (introduction of /csrf endpoint)
3 participants