Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

header_files should be filtered using template_files #58

Open
jwillemsen opened this issue Jun 22, 2018 · 5 comments
Open

header_files should be filtered using template_files #58

jwillemsen opened this issue Jun 22, 2018 · 5 comments

Comments

@jwillemsen
Copy link
Member

jwillemsen commented Jun 22, 2018

Some projects are using the template_files section also to list the template header files so that they are combined with any template source file. For those projects it would help when MPC would filter any file from template_files also from header_files.
As example, when template_files contains foo_t.h it should be removed from header_files

@jwillemsen
Copy link
Member Author

Possible solutions are #56 and #57

@mitza-oci
Copy link
Member

Template_Files shouldn't contain Foo_T.h, that's just an error on the user's part. See the "Component Names and Default Values" table in MakeProjectCreator.html

@jwillemsen
Copy link
Member Author

Ok, the table says the default values, seems some projects are putting the headers there, wanted to prevent manual updates to those mpc files, but if you say it is an user error which now results in not loading projects we have to update all mpc files

@mitza-oci
Copy link
Member

Which .mpc files are impacted? Just in ACE_TAO or elsewhere?

@jwillemsen
Copy link
Member Author

It was in another project where I am using MPC, haven't checked yet the full ATCD repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants