Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ACE_Auto_String_Free::operator bool #2263

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add ACE_Auto_String_Free::operator bool #2263

wants to merge 4 commits into from

Conversation

likema
Copy link
Contributor

@likema likema commented Jul 27, 2024

For if (s) and if (!s)

@jwillemsen
Copy link
Member

Use nullptr, test missing

jwillemsen
jwillemsen reviewed Jul 27, 2024
View reviewed changes
ACE/tests/SString_Test.cpp
ACE_ERROR_RETURN ((LM_ERROR,
ACE_TEXT ("ACE_Auto_String_Free is nullptr")),
1);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also test when it is nullptr

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test with a ACE_Auto_String_Free which is empty

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwillemsen jwillemsen jwillemsen left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@likema @jwillemsen