Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated WCS4_UTF16 to allow four octet wchar_t characters to marshal … #2146

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wkbrd
Copy link
Contributor

@wkbrd wkbrd commented Oct 17, 2023

…properly on Linux

Associated to #2145

mitza-oci
mitza-oci previously approved these changes Oct 19, 2023
if (this->write_4 (cdr, &l) && x != 0)
{
this->write_2 (cdr, &bom);
len--;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefix decrement

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated commit just pushed. Let me know if you have other comments. Thanks!

@jwillemsen
Copy link
Member

Can you add/extend one of the unit tests as reproducer?

@wkbrd
Copy link
Contributor Author

wkbrd commented Oct 20, 2023

Can you add/extend one of the unit tests as reproducer?

Hi, I am willing to try to create a test, though I have not written or used any tests in the past. Is there any guidance as to where they are or how to build them? Is there an existing test that would make sense as the place to start from?

@jwillemsen jwillemsen added the needs review Needs to be reviewed label Oct 25, 2023
@jwillemsen jwillemsen removed their request for review July 15, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Needs to be reviewed
Development

Successfully merging this pull request may close these issues.

3 participants