Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use unique_ptr instead of auto_ptr #1589

Closed
wants to merge 11 commits into from

Conversation

ClausKlein
Copy link
Contributor

to prevent compile problems with c++17 std

to prevent compile problems with c++17 std
@ClausKlein ClausKlein mentioned this pull request Jul 5, 2021
ACE/ace/Auto_Ptr.h Outdated Show resolved Hide resolved
Copy link
Member

@jwillemsen jwillemsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

NOTE: ACE_Auto_Basic_Array_Ptr or ACE_Auto_Array_Ptr is stil used
@ClausKlein ClausKlein marked this pull request as draft July 5, 2021 10:31
@jwillemsen jwillemsen removed their request for review July 5, 2021 11:11
@jwillemsen jwillemsen added the needs review Needs to be reviewed label Jul 5, 2021
prevent compile error on windows:

ace\ace\svc_conf_lexer.cpp(431): error C2668:
'std::unique_ptr<char,std::default_delete<_Ty>>::unique_ptr': ambiguous
call to overloaded function
@ClausKlein ClausKlein marked this pull request as ready for review July 6, 2021 05:27
ACE/ace/Svc_Conf_Lexer.cpp Outdated Show resolved Hide resolved
@ClausKlein
Copy link
Contributor Author

Note: this is a first step only!

ACE_Auto_Basic_Array_Ptr or ACE_Auto_Array_Ptr still used in ace/:

./ACEXML/common/HttpCharStream.cpp
./ACEXML/common/URL_Addr.cpp
./ACEXML/common/XML_Codecs.cpp
./ACEXML/parser/parser/Parser.h
./Kokyu/Default_Dispatcher_Impl.h
./ace/Auto_Ptr.cpp
./ace/CDR_Stream.cpp
./ace/Configuration.cpp
./ace/DLL_Manager.cpp
./ace/Local_Memory_Pool.cpp
./ace/Local_Name_Space_T.cpp
./ace/Log_Record.cpp
./ace/OS_NS_unistd.cpp
./ace/Parse_Node.cpp
./ace/Process.cpp
./ace/Refcounted_Auto_Ptr.h
./ace/Remote_Name_Space.cpp
./ace/SOCK_SEQPACK_Association.cpp
./ace/Sock_Connect.cpp
./ace/TLI.cpp
./ace/UUID.cpp
./apps/JAWS/clients/Caching/Locator_Request_Reply.cpp
./apps/JAWS/server/JAWS_IO.cpp
./apps/gperf/src/Key_List.cpp
./examples/C++NPv2/Reactor_Logging_Server_Adapter.cpp
./examples/IPC_SAP/UPIPE_SAP/ex2.cpp
./examples/IPC_SAP/UPIPE_SAP/ex3.cpp
./examples/Reactor/TP_Reactor/client.cpp
./examples/Web_Crawler/HTTP_URL.cpp
./netsvcs/lib/Client_Logging_Handler.cpp
./netsvcs/lib/Name_Handler.cpp
./protocols/ace/HTBP/HTBP_Channel.cpp
./protocols/ace/HTBP/HTBP_ID_Requestor.cpp
./protocols/ace/HTBP/HTBP_Inside_Squid_Filter.cpp
./protocols/ace/HTBP/HTBP_Session.cpp
./protocols/ace/INet/BidirStreamBuffer.h
./protocols/ace/INet/BufferedStreamBuffer.h
./protocols/ace/INet/HTTP_BasicAuthentication.cpp
./protocols/ace/RMCast/Link.cpp
./tests/CDR_File_Test.cpp
./tests/CDR_Test.cpp
./tests/Codecs_Test.cpp
./tests/Conn_Test.cpp
./tests/Log_Msg_Test.cpp
./tests/Message_Queue_Test_Ex.cpp
./tests/Reactor_Fairness_Test.cpp
./tests/Reactor_Performance_Test.cpp
./tests/Reactor_Remove_Resume_Test.cpp
./tests/SString_Test.cpp

FIXME: ./ace/Svc_Conf_Lexer.cpp: ACE_Auto_Ptr X ## bufp (0); \

@jwillemsen jwillemsen removed their request for review July 7, 2021 06:13
@ClausKlein ClausKlein closed this Jul 27, 2021
@jwillemsen
Copy link
Member

See #2109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Needs to be reviewed
Development

Successfully merging this pull request may close these issues.

2 participants