From 315c813b4bc03b9bbaa3c8e3c3c42bf1fd9249ff Mon Sep 17 00:00:00 2001 From: Luiz Silva Date: Thu, 27 Oct 2022 15:59:33 +1100 Subject: [PATCH 1/5] Replace number (deprecated) with numeric on random_string --- lambda-slack.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lambda-slack.tf b/lambda-slack.tf index 2fc78b1..cbb3c9a 100644 --- a/lambda-slack.tf +++ b/lambda-slack.tf @@ -60,7 +60,7 @@ resource "random_string" "lambda_suffix" { length = 8 special = false lower = true - number = false + numeric = false } resource "aws_lambda_function" "default" { From 727044b52d430419d560921f07dc25070e92d09c Mon Sep 17 00:00:00 2001 From: Luiz Silva Date: Thu, 27 Oct 2022 16:08:06 +1100 Subject: [PATCH 2/5] Fix Minimum version check --- .github/workflows/lint.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index d2cdff6..890f9b2 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -58,7 +58,11 @@ jobs: env: AWS_REGION: 'us-east-1' TF_WARN_OUTPUT_ERRORS: 1 + TF_VAR_vpc_id: 'vpc-123456' + TF_VAR_subnets: '["subnet-12345a"]' + TF_VAR_workers_ami_id: 'ami-123456' + TF_VAR_cluster_name: 'test_cluster' run: | sed -i -e 's/>=/=/' -e 's/ \(\d\+\.\d\+\)"/ \1.0"/' versions.tf terraform init - terraform validate -var "region=${AWS_REGION}" -var "vpc_id=vpc-123456" -var "subnets=[\"subnet-12345a\"]" -var "workers_ami_id=ami-123456" -var "cluster_ingress_cidrs=[]" -var "cluster_name=test_cluster" \ No newline at end of file + terraform validate \ No newline at end of file From beeef70c66bc80782d83017982bb887144e78566 Mon Sep 17 00:00:00 2001 From: Luiz Silva Date: Thu, 27 Oct 2022 16:11:19 +1100 Subject: [PATCH 3/5] Fix Minimum version check #2 --- .github/workflows/lint.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 890f9b2..2e72b2e 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -63,6 +63,5 @@ jobs: TF_VAR_workers_ami_id: 'ami-123456' TF_VAR_cluster_name: 'test_cluster' run: | - sed -i -e 's/>=/=/' -e 's/ \(\d\+\.\d\+\)"/ \1.0"/' versions.tf terraform init terraform validate \ No newline at end of file From 65738bfe88d1b257a1429556a8e89f671dca6007 Mon Sep 17 00:00:00 2001 From: Luiz Silva Date: Thu, 27 Oct 2022 16:12:43 +1100 Subject: [PATCH 4/5] Fix terraform formatting --- lambda-slack.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lambda-slack.tf b/lambda-slack.tf index cbb3c9a..755f085 100644 --- a/lambda-slack.tf +++ b/lambda-slack.tf @@ -60,7 +60,7 @@ resource "random_string" "lambda_suffix" { length = 8 special = false lower = true - numeric = false + numeric = false } resource "aws_lambda_function" "default" { From b001be9825d9e65955e1c6ef91a835aa691e7316 Mon Sep 17 00:00:00 2001 From: Luiz Silva Date: Thu, 27 Oct 2022 16:14:39 +1100 Subject: [PATCH 5/5] Change terraform image to latest --- .github/workflows/lint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 2e72b2e..f55c8dc 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -51,7 +51,7 @@ jobs: name: Minimum version check runs-on: ubuntu-latest container: - image: hashicorp/terraform:0.12.0 + image: hashicorp/terraform:latest steps: - uses: actions/checkout@master - name: Validate Code