Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need add test for that libspdm properly calls and handles the verify cert callback functions #2696

Open
Wenxing-hou opened this issue May 13, 2024 · 0 comments
Labels
test For tests and testing infrastructure

Comments

@Wenxing-hou
Copy link
Contributor

Refer to the PR: #2672 feedback,

Testing that libspdm properly calls and handles the output of Integrator-provided functions.
For example there is currently no coverage for verify_peer_spdm_cert_chain in [GET_CERTIFICATE] and encapsulated [GET_CERTIFICATE].
This would be tested in the unit tests for the corresponding SPDM message. For example test_spdm_requester/get_certificate.c.
Note that the callback function used for testing need not be elaborate. It can just return true or false.

Need add the unit_test for that libspdm properly calls and handles the verify cert callback functions.

@steven-bellock steven-bellock added the test For tests and testing infrastructure label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test For tests and testing infrastructure
Projects
None yet
Development

No branches or pull requests

2 participants