Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Fortran interface: autotools & CMake #1255

Merged
merged 60 commits into from
Oct 1, 2024
Merged

Conversation

jmark
Copy link
Collaborator

@jmark jmark commented Sep 24, 2024

Describe your changes here:

Title says it all.

Closes #1214.

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one)

.github/workflows/tests_cmake_t8code.yml Outdated Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
@jmark jmark mentioned this pull request Sep 27, 2024
14 tasks
@jmark
Copy link
Collaborator Author

jmark commented Sep 27, 2024

@Davknapp @sandro-elsweijer No idea why t8code_api_tests is skipped.

@jmark jmark assigned Davknapp and sandro-elsweijer and unassigned jmark Sep 27, 2024
@sandro-elsweijer
Copy link
Collaborator

@Davknapp @sandro-elsweijer No idea why t8code_api_tests is skipped.

But I do, will fix in on Monday

@sandro-elsweijer
Copy link
Collaborator

sandro-elsweijer commented Sep 30, 2024

@Davknapp @sandro-elsweijer No idea why t8code_api_tests is skipped.

But I do, will fix in on Monday

@jmark The workflow is now enabled

@Davknapp Davknapp merged commit d3d337d into main Oct 1, 2024
27 checks passed
@Davknapp Davknapp deleted the feature-fortran-interface branch October 1, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake Is about the CMake build system Fortran next release For the next release priority: high Should be solved as soon as possible workload: medium Would take a week or less
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

CI: Activate "enable-fortran" in our CI tests
5 participants